Add mvid and mdtoken to callstackframe #6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes largely look good to me so far, the outstanding things I'm aware of are:
|
....Diagnostics.Monitoring.StartupHook.UnitTests/Exceptions/Eventing/ExceptionsEventListener.cs
Show resolved
Hide resolved
…SFT/dotnet-monitor into dev/willxie/mvid_mdt
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/StacksTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.Diagnostics.Monitoring.UnitTestApp/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
schmittjoseph
added
the
update-release-notes
...iagnostics.Monitoring.StartupHook/Exceptions/Identification/ExceptionGroupIdentifierCache.cs
Show resolved
Hide resolved
...agnostics.Monitoring.StartupHook.UnitTests/Exceptions/Eventing/ExceptionsEventSourceTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/StacksTests.cs
Show resolved
Hide resolved
wiktork
previously approved these changes
Jun 19, 2024
…SFT/dotnet-monitor into dev/willxie/mvid_mdt
schmittjoseph
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds moduleVersionId guid and methodDef token to callstack frames.
Example output from invoking /exceptions route:
{ "id": 40, "timestamp": "2024-06-14T23:39:07.9509456Z", "typeName": "AppDiagnosticsNet6.Controllers.MyException", "moduleName": "AppDiagnosticsNet.dll", "message": "I have an inner exception.", "activity": { "id": "00-5e1784b5de0c77f7fb60abed6e43f3b9-ecd287b342b2dcec-00", "idFormat": "W3C" }, "innerExceptions": [ { "id": 39 } ], "stack": { "threadId": 49328, "threadName": null, "frames": [ { "methodName": "ThrowInnerException", * "methodToken": 100663635, "parameterTypes": [], "typeName": "AppDiagnosticsNet6.Controllers.ExceptionsController", "moduleName": "AppDiagnosticsNet.dll", * "moduleVersionId": "bf769014-c2e2-496a-93b7-76fbbcd04be5" },Release Notes Entry
CallStackFrame JSON results now include methodtoken and moduleversionid.